Comment 5 for bug 1092911

Revision history for this message
Peter Petrakis (peter-petrakis) wrote :

SUMARRY : module-init-tools and binutils must be added to "Depends"

$ bzr branch lp:ubuntu/crash
Most recent Ubuntu version: 6.1.0-1ubuntu1

$ cd crash

<01:21:16>crash$ bzr grep Depends debian/
debian/changelog: libncurses in ${shlibs:Depends} (Closes: #318367)
debian/control:Build-Depends: debhelper (>= 9), dpkg-dev (>= 1.16.1), quilt (>= 0.47), binutils, binutils-dev, zlib1g-dev, libncurses5-dev
debian/control:Depends: ${shlibs:Depends}, ${misc:Depends}

So it's a build depend but it was left to library auto-resolution to determine shared
library depends. "strings" is being called as a normal process. We have explicitly
add binutils to Depends.

kernel.c: sprintf(command, "/usr/bin/strings %s", namelist);
kernel.c: sprintf(command, "/usr/bin/strings %s", namelist);

In addition to that:
filesys.c: sprintf(command, "/sbin/modprobe %s", pc->memory_module);
filesys.c: sprintf(command, "/sbin/rmmod %s", pc->memory_module);

We get these for free as basic kernel utils are always expected to be installed.

and that's just from grepping the code for 5 mins.