Comment 101 for bug 1751460

Revision history for this message
In , Ysuzuki-z (ysuzuki-z) wrote :

(In reply to Michael Catanzaro from comment #43)
> Comment on attachment 340850 [details]
> Patch
>
> Well I'm not sure if we should do this, because Gigacage is an important
> security feature. There are some notes at
> https://labs.mwrinfosecurity.com/blog/some-brief-notes-on-webkit-heap-
> hardening/ about all the hardening features that this will silently disable.
>
> But I guess not crashing is good, so r=me.
>
> Did you try Florian's suggestion? Were there problems with performance?

Currently, I'm not trying this.
I think currently this patch is OK since it avoids crashing. And users can enable gigacage by enabling overcommit :)