Ubuntu
desktop-file-utils package

  1. Bug #43977
  2. Comment #15

Comment 15 for bug 43977

Revision history for this message
Gary Coady (garycoady) wrote : Re: [Bug 43977] Re: desktop-file-utils -q always segfaults

Sebastien Bacher wrote:
> Gary, thank you for the work on that. You use "if (p > q && p[-1] == '\\' && error == NULL)"
>
> " string_value = g_new (gchar, length);
>
> p = (gchar *) value;
> q = string_value;
> ..."
>
> they are different variables, what "p > q" verifies for you? I would rather use "p > value" as condition, what do you think about it?

While I'd hate to admit to making a mistake, you're right. p and q are
completely unrelated (as regards where they are in memory), and I agree
with using that condition instead.