Comment 14 for bug 1248054

Hello,

I would suggest a few modifications :

1) lockfile="/var/run/$progdir/$NAME.pid"
 Should point to /run as /var/run is a symbolic link

2) Your mount statement should terminate by : || true as in

mount -t configfs none /sys/kernel/config > /dev/null 2>&1 || true

If the mount fails for any reason the fact that the shell runs as -e will make the complete command fails badly.

3) The upstream has a systemd service ; shouldn't it be used instead of relying on the obsolete sysinit script ? While I understand that this is intended to be SRUed, the proper service should be used on Xenial anyhow.

pitti also commented that the script (if used) should go in /usr/lib/modules-load.d/ but that would not be required if we go with the systemd service.