Comment 16 for bug 1919322

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the review.

Lucas is off today, but I talked to him briefly about this SRU and here is the summary of the discussion:

1) According to Lucas, this should not be a problem because we are backporting a version from Hirsute, which already contains the postinst excerpt you're referring to (the ZFS one, if I'm understanding correctly). The extra hunk that is being added to the posting script is just related to ZFS, and it has been tested on Hirsute (as mentioned) and backported to Groovy already, and it's making its way down the line. Not sure if this answers the question; let me know if you need more details.

2) Indeed, we need a trasitional package for this one. I am working on it, and will ping someone an AA before proceeding with the upload. I have already left a message on #ubuntu-release to the archive admins asking for a pre-approval before I go ahead and upload.

3) The change is intentional and comes from upstream. I tracked it to the following commit:

https://github.com/moby/moby/commit/28e93ed8caad2c15d2b3b704801c71b9584de91e

Which, according to the description, was made because PartOf deactivates the socket when the service gets deactivated, which shouldn't happen. This makes sense to me, and historically the systemd bits from these packages have always come from upstream, without any distro-specific change required.