Comment 8 for bug 823640

Revision history for this message
Sebastien Bacher (seb128) wrote :

> Upstream has indicated they are not averse to accepting our work but we have not yet submitted it due to project timing issues. I can prefix the functions if you still think it's a good idea.

better to do it for now yes, those are not public api and easy enough to rename when submitting to upstream when we do that

> With scroll-to-zoom enabled pinch-to-zoom becomes unusable with touchpads since the underlying hardware is detecting scroll gestures during pinch gestures

I'm not sure to understand why changing the behaviour between zoom and scroll fix that issue, do you mean that instead of conflicting zoom you will get scrolling while zooming? Isn't that confusing as well?

> The version of EOG in previous Ubuntu releases did not have scroll-to-zoom enabled by default. This patch reverts to that behaviour so there is no functional regression and gestures work. I do not have a problem undoing that aspect of the patch and simply documenting that using your touchpad will require the installation of a dconf settings app and using that to change settings.

Right, but it was changed to be the default and it's probably for a reason ;-) It seems much easier to zoom in and out using the mouse that having to select toolbar options and click, also vertical scrolling with the mouse tends to be useless because you can't to horizontal scrolling on most mouses which you are likely going to need, better to click and dnd for that

If we can get the 2 features to conflict I think we should still default to the settings which make sense for mouse users because that's what most Ubuntu users still run