Comment 2 for bug 1865523

# For Ubuntu Bionic:

Okay, after bisecting fence-scsi and monitoring all its functions I was able to isolate the patches that I need to take to bionic to make it compatible with existing version and, at the same time, operational:

Note: all tests were conducted with Pacemaker v1.1.19-0ubuntu1 and this is not the default in Ubuntu Bionic. I have maintained "vanilla" Pacemaker v1.1.19 in order to better isolate all fixes for fence-agents. Now I'm able to create a fixed fence-agent package for Ubuntu Bionic AND fix Pacemaker.

# Ubuntu Bionic SRU: Fence Agents v4.0.25 PLUS the following fixes/commits ordered by date:

commit 81b8370844f5aecaee5e7178d82670c70399d824
Author: Oyvind Albrigtsen <email address hidden>
Date: Mon Jul 24 14:12:15 2017

    fence_scsi: add FIPS support

commit eae9d029b7073e7eb8c7ba4df9ec19b755a8f603
Author: Oyvind Albrigtsen <email address hidden>
Date: Wed Sep 27 12:26:38 2017

    fix for ignored options

commit c6f29a653114523e9ac3644aed958b4bb43f3b41
Author: Oyvind Albrigtsen <email address hidden>
Date: Wed Sep 27 12:42:39 2017

    Maintain ABI compatibility for external agents

commit 746fd55b061aa28b27aac5a1bb38714a95812592
Author: Reid Wahl <email address hidden>
Date: Fri Apr 6 18:31:30 2018

    Low: fence_scsi: Remove period from cmd string

commit bec154345d2291c9051c16277de9054387dc9707
Author: Oyvind Albrigtsen <email address hidden>
Date: Thu Apr 19 11:30:53 2018

    fence_scsi: fix plug-parameter and keep support for nodename to avoid regressions

commit 335aca4e54e4ec46b9b5d86ef30a7d9348e6a216
Author: Valentin Vidic <email address hidden>
Date: Wed May 23 12:51:23 2018

    fence_scsi: fix python3 encoding error #206

commit f77297b654586bf539e78957f26cae1d22c6f081
Author: Oyvind Albrigtsen <email address hidden>
Date: Fri Nov 2 08:24:56 2018

    fence_scsi: fix incorrect SCSI key when node ID is 10 or higher

      The last four digits of the SCSI key will be zero padded digit between 0000-0009.

commit 1c4a64ca803831b44c96c75022abe5bb8713cd1a
Author: Oyvind Albrigtsen <email address hidden>
Date: Wed May 22 08:13:34 2019

    fence_scsi: detect node ID using new format, and fallback to old format
    before failing