Comment 7 for bug 595609

Revision history for this message
Bhavani Shankar (bhavi) wrote :

Hello Bilal again!

Here is a review again:-

1.Point number 1 in my review of apt-cacher merge holds good here too

2. Why are you including reverted changes to the debian source in your ubuntu version diff to make the diff large? Please remember this point as stated in merges.ubuntu.com before submitting a diff:-

"Try and keep the diff small, this may involve manually tweaking po files and thelike."

3. I see no real reason for merging as there is only a maintainer and homepage change and I dont see any significant changes apart from that in the recent debian changelog and we can wait till debian releases a new upstream release I think (please correct me if I am wrong):-

 filtergen (0.12.4-5) unstable; urgency=low

   * New maintainer. Closes: #543434.
   * Bump standards version:
     - Added Homepage field.

 -- Matt Palmer <email address hidden> Tue, 02 Feb 2010 16:51:39 +1100

Also you can forward ubuntu changes to debian (via submittodebian in ubuntu-dev-tools) to see if the debian maintainer is interested in applying ubuntu changes so that we can keep the package in sync with the debian archive which reduces merging workload.

Regards