Comment 15 for bug 532722

Revision history for this message
Loïc Minier (lool) wrote :

Some small suggestions on the shell script:
- mktemp /tmp/"$me-XXXXXX" => mktemp -t "$me-XXXXXXXX"
- instead of echo -n + final echo, why not just accumulate defines in a string which you output? e.g. DEFINES="", DEFINES="$DEFINES -DFOO" and echo "CFLAGS += $DEFINES"
- you could eval this from make instead of generating an intermediate make, but that's a bit harder to read I guess (avoids the chicken and egg between the include being missing before it's generated though)
- I personally do the tests directly in make, but you could also consider autoconf itself I guess

Thanks!