Ubuntu
firefox package

  1. Bug #1260788
  2. Comment #37

Comment 37 for bug 1260788

Revision history for this message
In , Edwin-d (edwin-d) wrote :

Created attachment 788730
WIP

Did a bit of hacking on this a couple weeks ago; thought I should put this up.

Fixed a couple seeking issues, and with that a few tests fixed themselves.

Also found that we'd get bogus metadata using anything other than the GST_VIDEO_FRAME_* macros on 1.0.

When upstream fails to negotiate the allocator, we used to instantiate one and then copy the buffer over. Now we just copy to a PlanarYCbCrImage directly.

Outstanding issues:
 * Some tests still fail.
 * gst_buffer_pool_config_get_video_alignment returns total rubbish, even when the option GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT is present. For now, gst_video_info_align is commented out.