Ubuntu
firefox package

  1. Bug #1871644
  2. Comment #33

Comment 33 for bug 1871644

Revision history for this message
In , Emilio (emiliocobos) wrote :

Well, perhaps, but that seems tangential to this bug, isn't it? We don't use XShapeCombineMask for the titlebar and this patch stack doesn't start doing that.

If we do want to do the cleanup described above, we might need a new media query which determines this (but it should definitely not have `csd` in the name, since it is not about csd at all). So I'd rather clean up the existing one since it's confusing at best.

Anyways, things I've tested:

 * KWin (Wayland/X11/XWayland)
 * GNOME (Wayland/X11/XWayland) with a variety of GTK themes
 * i3
 * bspwm

And in all cases this patch stack doesn't regress behavior (and improves it in the obvious cases). So I'd say comment 25 should be a separate bug?

If someone has an exotic setup and wants to give this a try before it lands, or wants to provide feedback, builds should be here eventually: https://treeherder.mozilla.org/jobs?repo=try&revision=327533608921f19068d1b8898b094fb3b3cdfc9d