Comment 9 for bug 48664

Revision history for this message
In , Ehsan Akhgari (ehsan) wrote :

Is there any special reason why this dialog has to be modal? Bug 267227 moved openAboutDialog() from browser.js to utilitOverlay.js (see the original version in browser.js: <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/browser.js&rev=1.402#2758>). I was able to track the change to here: <http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=/mozilla/browser/base/content&command=DIFF_FRAMESET&file=browser.js&rev2=1.34&rev1=1.33>. The changelog for rev 34 is: "Add note about a workaround." (<http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/browser/base/content/browser.js&rev=1.34>) which doesn't help a lot...

Does anybody know why this dialog should not be modal? I have a simple patch which I will attach shortly which makes this non-modal, and I can't seem to find any problem with a non-modal dialog. It only simplifies the use cases such as that in comment 0.