> @@ +928,5 @@
> > + default:
> > + break;
> > + }
> > +
> > + dbus_done:
>
> goto is unusual style and it's not appreciated in c++ world in general. I'm
> fine if you're sure to keep it
This code is pretty "Cish" because of the dbus api, and its a reasonably common view that gotos like this are good style for the special case of error handling in C.
> ::: widget/src/gtk2/nsWindow.cpp
> @@ +6479,1 @@
> > return;
>
> it appears nsWindow::Show() manages root accessible creation, so here you
> should check only if accessibility service instantiated.
you mean nsAccessibilityService::GetAccService() is non-null right?
> @@ +928,5 @@
> > + default:
> > + break;
> > + }
> > +
> > + dbus_done:
>
> goto is unusual style and it's not appreciated in c++ world in general. I'm
> fine if you're sure to keep it
This code is pretty "Cish" because of the dbus api, and its a reasonably common view that gotos like this are good style for the special case of error handling in C.
> ::: widget/ src/gtk2/ nsWindow. cpp
> @@ +6479,1 @@
> > return;
>
> it appears nsWindow::Show() manages root accessible creation, so here you
> should check only if accessibility service instantiated.
you mean nsAccessibility Service: :GetAccService( ) is non-null right?