Ubuntu
firefox package

  1. Bug #934887
  2. Comment #96

Comment 96 for bug 934887

Revision history for this message
In , Mh+mozilla (mh+mozilla) wrote :

Comment on attachment 598827
patch

Review of attachment 598827:
-----------------------------------------------------------------

::: config/autoconf.mk.in
@@ +43,5 @@
> MOZILLA_CLIENT = 1
> target = @target@
> ac_configure_args = @ac_configure_args@
> MOZILLA_VERSION = @MOZILLA_VERSION@
> +MOZILLA_UAVERSION = @MOZILLA_UAVERSION@

That shouldn't be needed.

::: configure.in
@@ +8911,5 @@
>
> AC_SUBST(WIN_TOP_SRC)
>
> AC_SUBST(MOZILLA_VERSION)
> +AC_SUBST(MOZILLA_UAVERSION)

That shouldn't be needed. AC_SUBSTs are only needed when the value needs to be used in makefiles, which it isn't.

::: js/src/config/autoconf.mk.in
@@ +43,5 @@
> MOZILLA_CLIENT = 1
> target = @target@
> ac_configure_args = @ac_configure_args@
> MOZILLA_VERSION = @MOZILLA_VERSION@
> +MOZILLA_UAVERSION = @MOZILLA_UAVERSION@

That's not needed.

::: js/src/configure.in
@@ +5229,5 @@
>
> AC_SUBST(WIN_TOP_SRC)
>
> AC_SUBST(MOZILLA_VERSION)
> +AC_SUBST(MOZILLA_UAVERSION)

That's not needed.