Comment 4 for bug 1962289

Revision history for this message
Loïc Minier (lool) wrote :

Hi there,

Thanks for the nice debdiffs; reading through these, I see the following changes:
1) a new boot script – fine, albeit flash-kernel seems to collect more and more of them and it would be good to avoid having too many
2) support for using the kernel ABI version in substs – why not, albeit it's a bit surprising this wasn't needed so far, and it looks like this might be breaking an abstraction
3) a new its file as a template for the FIT image; this one seems really wrong to me because it has this long list of dtbos which will likely evolve across kernel versions

IMO the job of flash-kernel is to keep track of the method with which we install kernels/initramfses/other boot assets, but once a method is implemented, it can be used for a long time. Here, the list of dtbos is very long and seems very platform specific, so it's likely to evolve with kernel versions, so it will likely result in having to update flash-kernel for a new kernel, or having to manage versioned dependencies like "at least this version of flash-kernel to get the its that installs this list of dtbos".

I'm not sure what the proper solution is, it could be that the its file should be provided by the kernel rather than flash-kernel, like dtbs, or perhaps we need to scan for dtbo files.

What would be really useful would be to explain how these dtbos are being used, what's the scenario in which they are used in the FIT image?

Thanks!