Comment 3 for bug 1527685

Revision history for this message
Steve Langasek (vorlon) wrote :

Hi Tiago,

Feedback on this merge:

 - your updated delta shows an added build-dependency on dh-autoreconf, which is correct; but the corresponding change to debian/rules to use dh-autoreconf at build time has been lost, and the change is not mentioned in the changelog.
 - you say in the changelog that debian/patches/dso-linking.patch is dropped because it has been applied upstream; but I am not able to find evidence of this.
 - your merge changelog lists various changes under the heading "Remaining changes" that are not remaining changes, but changes that have been dropped or superseded. I recommend listing dropped/superseded changes in a separate section in the changelog, with an explanation of why each is dropped. Some Ubuntu developers have a different opinion, but in any case you should not list as "remaining changes" things that are no longer part of the Ubuntu delta.

Please see attached my proposal for this merge.