Comment 16 for bug 8023

Revision history for this message
Amos Brocco (mriya3) wrote : Patch for libgnomecups to fix wrong IPP call to allow changing printer description and location from the properties window of gnome-cups-manager

This patch fixes a libgnomecups bug in the gnome_cups_printer_set_description and gnome_cups_printer_set_location functions (which are called by gnome-cups-manager when the description and location text entries are modified in the printer properties dialog).

The original methods called IPP_SET_PRINTER_ATTRIBUTES, but, as stated in http://lists.samba.org/archive/samba-technical/2003-February/027044.html is not implemented in CUPS. The patch changes the code so that CUPS_ADD_MODIFY_PRINTER is used. This way no error is produced and the location and description are correctly editable.

This patch along with the improved gnome-cups-add one (the second one I attached to this bug) solve the printer name/description/location bug completely, and allow setting the name/description/location for a while adding a new printer as well as description and location for already installed printers.