Comment 20 for bug 1802614

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

[Summary]
MIR Team Ack
List of specific binary packages to be promoted to main: gnome-remote-desktop

Required TODOs:
- none

Recommended TODOs:
- d/watch seems broken, mid term fix it so that tools that check if things
  are outdated will work well.

[Duplication]
Well, we have the programs doing the same for just X11 stack, but it was already
mentioned that this will likely be later on demoted. So no conflict for
duplication.

[Dependencies]
OK:
- no other Dependencies to MIR due to this (pipewire is ready for promotion)
- no -dev/-debug/-doc packages that need exclusion

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking

[Security]
OK:
- history of CVEs does not look concerning
- does not use webkit1,2
- does not use lib*v8 directly
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)

Problems:
- does run a daemon as root
- does parse data formats
- does open a port

This would usually indicate a security review, but that was already done.

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- The package has a team bug subscriber
- not a python/go package, no extra constraints to consider int hat regard
- no new python2 dependency

Problems:
- test suite does not fail the build upon error.
- does not have a test suite that runs as autopkgtest

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- Upstream update history is (good/slow/sporadic)
- Debian/Ubuntu update history is (good/slow/sporadic)
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- d/rules is rather clean
- Does not have Built-Using

Problems
- d/watch is present but does not work (this is no blocker)

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as I can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- part of the UI for extra checks
  - no desktop file, but it is just integrated differently, so ok