Comment 7 for bug 1838152

Revision history for this message
Robie Basak (racb) wrote :

Disco and Eoan are EOL though, and Focal looks like it already has upstream commit 19e0840 included. So isn't it your proposed Bionic upload that would be different? Why not look into making that the same as what is in Focal?

Regardless, I'd like you to please at least consider the possibility that cherry-picking only 86a00b6 from upstream is an incomplete fix to this bug and look into further upstream changes to that file since that commit to see if 19e0840 or others are relevant. If after understanding the relevant changes you conclude that there is still a benefit to SRU this as-is, can explain the trade-off in not also taking the other relevant changes and can make the case for 19e0840 being correct on its own, then I'll consider that.

As it stands it appears to me that 19e0840 contains an oversight that was since corrected upstream, but your SRU doesn't include the correction. Unless you change my mind, I don't consider this acceptable for SRU.