Comment 4 for bug 236305

Revision history for this message
Brian Fallik (bfallik-litl) wrote :

Looking at the source, I think this snippet:
                group = oobs_group_new (name);
                oobs_group_set_gid (group, group_settings_find_new_gid ());
is missing a check before oobs_group_new to bail out early if the name already exists in the configuration.

Also, the code flow in get_main_group() method seems strange. If gtk_combo_box_get_active_iter(...) returns True, the method seems to return the uninitialized pointer 'group'. Of course I don't know the code very well so maybe it's not a problem, but it seems suspicious.