Comment 2 for bug 133327

Revision history for this message
Zizzle (mattpratt) wrote :

I was still seeing this leak in gutsy so I pulled the source, built debug packages and ran them under valgrind:

==7125== 3,776 bytes in 472 blocks are definitely lost in loss record 7 of 12
==7125== at 0xFFBAF40: malloc (vg_replace_malloc.c:149)
==7125== by 0xFE588F8: g_malloc (in /usr/lib/libglib-2.0.so.0.1400.1)
==7125== by 0xFE723B4: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.1400.1)
==7125== by 0xFE73A74: g_slist_prepend (in /usr/lib/libglib-2.0.so.0.1400.1)
==7125== by 0x10012C88: hal_device_store_match_multiple_key_value_string (device_store.c:425)
==7125== by 0x10039184: pmu_poll (pmu.c:268)
==7125== by 0xFE50094: (within /usr/lib/libglib-2.0.so.0.1400.1)
==7125== by 0xFE4F720: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.1400.1)
==7125== by 0xFE539A4: (within /usr/lib/libglib-2.0.so.0.1400.1)
==7125== by 0xFE53E10: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.1400.1)
==7125== by 0x100140B8: main (hald.c:656)

So I created a patch to fix the leak and thought I would send a copy to the last person to touch the pmu.c file. To find this I looked at the hal git repo. Seems I was a bit late someone beat me to it:

http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=1491787fdf29fd77e4cbd13af70434ee3e7032ee