Comment 3 for bug 1771557

Revision history for this message
Eric Desrochers (slashd) wrote :

Uploaded in Trusty upload queue. It is now waiting on SRU verification team approval to start building in trusty-proposed.

# Sponsoring note

[Nitpick]
- Add (LP: #1771557) in debian/changelog

[Note]
* The sed command seems pretty solid. The "*" is indeed a good idea, even if IMHO unlikely to exceed 2 digits if it happen the cmd will match any number that precedes "n", "p" and the end, even if exceeding 2 digits.
* I don't have an NVMe drive handy, but I know gpicolli did all the necessary validation pre-SRU.

[Manual verification]

Testing different nvme drive naming scenarios:

$ echo "nvme1n2p3" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g'
nvme1n2

$ echo "nvme11n22p33" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g'
nvme11n22

$ echo "nvme11n22p33" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g'
nvme11n22

$ echo "nvme111n222p333" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g'
nvme111n222

$ echo "nvme1111n2222p3333" | sed 's/\(nvme[0-9][0-9]*n[0-9][0-9]*\)p[0-9]*/\1/g'
nvme1111n2222