Comment 28 for bug 2031412

Hi,

this review is about the ipu6-driver portion of this SRU, which I will paste below and add inline comments to:

> ========== ipu6-driver ==========
>
> [Impact]
>
> Missing Intel MIPI firmware for Meteor Lake platform.

The changes in ipu6-drivers are not adding a new firmware as far as I can tell, could you please clarify?

Overall, after this update, what will be the status of MIPI cameras for mantic users on intel meteor lake?

>
> [Fix]
>
> Based on upstream tag https://github.com/intel/ipu6-drivers/releases/tag/Release_20231019, and an additional patch to enable/fix compilation of additional sensor modules.

Since this includes a new upstream code drop, could you summarize the highlights? Have you inspected them for backwards incompatible changes?

>
> [Test Case]
>
> This is verified on MTL Lattice and VSC platforms, as well as previous generations e.g. TGL and ADL.
>
> To actually verify the camera framework:
> ```
> $ sudo add-apt-repository ppa:oem-solutions-group/intel-ipu6
> $ sudo add-apt-repository ppa:canonical-hwe-team/intermediate-kernel
> $ sudo apt install linux-oem-22.04d-exp
> $ sudo apt install linux-modules-ipu6-oem-22.04d-exp
> $ sudo apt install linux-modules-ivsc-oem-22.04d-exp
> $ sudo apt install linux-modules-usbio-oem-22.04d-exp
> $ sudo apt install gstreamer1.0-icamera v4l2-relayd
> ```
> And then browse https://webcamtests.com/ for testing.

Like my comment #24 above, is there a way to test this that does not involve out-of-archive packages? If not, what is the benefit of this update to mantic users?

>
> [Where problems could occur]
>
> This is a new platform. We've been verifying its functions and features, and
> are still polishing it.

That doesn't sound very reassuring :) Having said that, you think it's ready for a stable release update for mantic users? Mantic users will benefit from this update?

>
> [Other Info]
>
> While Intel Meteor Lake is only supported by linux-oem-6.5/jammy and
> linux/mantic and on, and yet the lastest stable driver was verified after Mantic was released, it's being proposed to Noble instead.