© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Curtis,
This looks good. A few minor things:
1. Please run update-maintainer so as not to make the Debian mongodb maintainer appear to be responsible for this package.
2. Architecture list in d/control: we prefer to just say "Architecture: any" and let things FTBFS on architectures we are not directly targeting. This makes life easier for porters, for example xnox. Please update the architecture lists to xnox's satisfaction.
3. Quilt patch drops are misleadingly documented, since patches have changed as well as been dropped. Maybe it's easier to just say that you've synced upstream patches with the mongodb 1:2.6.10-0ubuntu1 from the archive? I'd be fine with that as a changelog entry.
4. As discussed on IRC, since you based this on ubuntu4 and we've had 5 and 6, there are some things that could have been dropped. Please can you check this? If everything is fine, just document that in the changelog.
5. As discussed on IRC, xnox doesn't want this to regress over architecture support he ported in juju-mongodb 2.4. Please could you coordinate with him to reach a conclusion on this? I don't care what you do here as long as xnox is happy. This may involve adding patches. If you add patches to juju-mongodb, it may make sense to also add them to mongodb and/or send things to Debian or upstream. Then our diffs would remain smaller for the future.
I'm happy to upload if the above is resolved (even if that means no action). In the longer term, it may be worth figuring out a workflow to keep these Juju-specific mongodb packages updated, as we expect a number of them. The server team's new git-based workflow for merges might be worth looking at, since one thing in common is the need to maintain a delta against something else, and verifying that delta when we bump upstream versions.