Comment 6 for bug 1557830

Thanks, this looks good.

AFAICS, the quilt patches in Ubuntu mongodb 1:2.6.10-0ubuntu1 apply with only offset, not fuzz. This is allowed, so refreshing wasn't necessary. I can see that your refresh (and one line of series being moved) is effectively a no-op but it would be easier for me if we didn't refresh things unnecessarily to reduce review diff. Similarly the change to COMMON_OPTIONS in debian/rules just adds diff and is a no-op, so I'd prefer not to have it.

I'm not sure what approach to take against mongodb 3.2 here though, as there's nothing really to diff against except 2.6.

I've also been grappling a little with coming up with a good review strategy for these packages in general. I ended up using meld to examine a 3-way diff between your tree, Ubuntu mongodb 1:2.6.10-0ubuntu1 and Ubuntu juju-mongodb 2.4.10-0ubuntu6. I'm much happier now that I can see better what you changed, though I will have to do something different for 3.2. With this though, I found a couple of other things that I missed before. Sorry to go back to you again on this.

Ubuntu mongodb 1:2.6.10-0ubuntu1 introduced --use-system-v8, but you haven't carried this forward. Is this expected (not described in changelog)? Perhaps it is because of --disable-scripting but I'm not sure.

You also introduced a nocheck wrapper around override_dh_auto_build which isn't in any of the base versions. This looks unintentional to me, or was it intended?