Comment 15 for bug 244838

Revision history for this message
ceg (ceg) wrote : Re: remove laptop-mode settings from /etc/default/acpi-support

This bug as about the ENABLE_LAPTOP_MODE having nothing to do in package acpi-support (another package).
(It was introduced there because some ubuntu dev once stuck an old unmaintained laptop_mode scipt into acpi-support instead of using proper laptop-mode-tools package, and later laptop-mode-tools got patched to use that setting.)

Removing the setting will *not* enable laptop-mode by default, because it is still checking if it is enabled in /etc/default/laptop-mode and /etc/laptop-mode/laptop-mode.conf (where it is enabled only if on battery).

What's still left from this in order to reduce the number of ubuntu mispatches is:

acpi-support:
 * Simply remove that setting form /etc/default/acpi-support

 If the laptop-mode-tools package does not get installed by default any more, is a separate question.

laptop-mode-tools:
 * The package might wrongly restrict the installation of /etc/default/laptop-mode only to powerpc instead of restricting the install of /etc/power only to powerpc. (->Bug #491804 ) (Still, if the file is not there ENABLE_LAPTOP_MODE won't be true)

 * eventually remove checking of /etc/default/acpi-support

-----
About "kernel's laptop_mode has been hardcoded to be enabled on battery".
This was true with that other (non-laptop-mode-tools package) laptop-mode script as long as it was packaged with acpi-support instead of relying on laptop-mode-tools (but conflicting with it). Bug #239419