Comment 7 for bug 244838

Revision history for this message
ceg (ceg) wrote : Re: remove laptop-mode settings from /etc/default/acpi-support

Yes, /etc/default/laptop_mode seems more sane as a second config file for laptop-mode-tools.

As you mentioned in Bug #250935 we have to keep in mind that enabling the laptop-mode-tools by default is in fact a necessary change to fix the load cycling issue for example.

IMHO laptop-mode-tools needs to be enabled by default. (/etc/default/laptop_mode does provide a place to optionally disable this autoinstalled package alltogether.)

Whether laptop_mode (ENABLE_LAPTOP_MODE_ON_BATTERY) is enabled or not by default is another question.

Since hardy, as a userfriendly distro suitable for laptops, has allways set /proc/sys/vm/laptop_mode to 2 when on battery ("laptop-tools" script hacked into pm-utils) I'd tend to propose that the laptop-mode.conf default (_ON_BATTERY=1) can just be kept. It steps in for the pm-utils script that got removed in intrepid.

Enabling laptop-mode-tools can be considered a necessary bugfix change, and not entering /proc/sys/vm/laptop_mode on battery any more can be considered a regression.

Looks as this would also make much transition magic unnecessary. The comment that debian packages have in place might suffice.