Ubuntu
libaccounts-glib package

  1. Bug #1029549
  2. Comment #29

Comment 29 for bug 1029549

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Review:
 * No CVEs. Hardening options are enabled, but it would be nice to have this compiled with PIE. No initscripts/upstart jobs, dbus services, setuid, use of fscaps, use of sudoe/su/pkexec, or cron jobs
 * coded in typical C++ and looks to have appropriate SSL handling. Spot checking code looks fine.
 * Has testsuite and it is enabled in the build
 * libqtwebkit-dev dependency is thankfully dropped
 * no errors or important warnings in the build
 * is not lintian clean:
signon-plugin-oauth2-tests_0.11-0ubuntu2_amd64.deb:
W: signon-plugin-oauth2-tests: binary-without-manpage usr/bin/oauthclient
W: signon-plugin-oauth2-tests: binary-without-manpage usr/bin/signon-oauth2plugin-tests

ACK