Ubuntu
libssh2 package

  1. Bug #681423
  2. Comment #6

Comment 6 for bug 681423

Revision history for this message
Kees Cook (kees) wrote :

I'd like to see a few things fixed up before this goes into main:

- build-time FORTIFY_SOURCE warnings should be appropriately fixed, for example:
  sftp.c: In function 'kbd_callback':
  sftp.c:78: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result
  sftp.c: In function 'main':
  sftp.c:259: warning: ignoring return value of 'write', declared with attribute warn_unused_result

- I'd like to see the upstream tests actually run at build-time

Beyond that, it looks fine to me.