Comment 13 for bug 955376

Revision history for this message
Steve Langasek (vorlon) wrote :

Please don't use 'fix committed' for Ubuntu stable release tasks, this value is used by the SRU process with a separate meaning.

The [Regression Potential] here asserts "Other sessions could not be affected" without explanation. It's not at all clear to me in reviewing the delta why that would be. For one thing, there are changes beyond the :backdrop addition:

+@@ -28,6 +32,7 @@
+ PanelApplet > GtkMenuBar.menubar.menuitem,
+ PanelMenuBar.menubar,
+ PanelMenuBar.menubar.menuitem {
++ -PanelMenuBar-icon-visible: true;
+ background-image: -gtk-gradient (linear, left top, left bottom,
+ from (shade (@dark_bg_color, 1.5)),
+ to (shade (@dark_bg_color, 1.05)));
+@@ -41,14 +46,15 @@
+ border-width: 0;
+ }
+
++PanelApplet .button:backdrop,
+ PanelApplet .button {
+ -GtkButton-inner-border: 2;
+
+ background-image: -gtk-gradient (linear, left top, left bottom,
+ from (shade (@dark_bg_color, 1.5)),
+ to (shade (@dark_bg_color, 1.05)));
+-
+- border-color: shade (@dark_bg_color, 0.78);
++ border-color: alpha (shade (@dark_bg_color, 1.0), 0.6);
++ border-left-color: alpha (shade (@dark_bg_color, 1.5), 0.3);
+ border-radius: 0;
+ border-width: 0 1px 0 1px;
+
+@@ -57,37 +63,27 @@
+
+ -unico-border-gradient: none;
+ -unico-glow-radius: 0;
+- -unico-inner-stroke-width: 0;
+- -unico-outer-stroke-width: 0;
++ -unico-inner-stroke-width: 0px;
++ -unico-outer-stroke-width: 0px;
+ }
+
+-PanelApplet .button:prelight:active,
++PanelApplet .button:active:prelight:backdrop,
++PanelApplet .button:active:prelight,
++PanelApplet .button:active:backdrop,
+ PanelApplet .button:active {
+ background-image: -gtk-gradient (linear, left top, left bottom,
+ from (shade (@dark_bg_color, 0.85)),
+ to (shade (@dark_bg_color, 1.0)));
+- border-color: shade (@dark_bg_color, 0.78);
+- border-radius: 0;
+- border-width: 0 1px 0 1px;
+-
+- -unico-border-gradient: none;
+- -unico-glow-radius: 0;
+- -unico-inner-stroke-width: 0;
+- -unico-outer-stroke-width: 0;
++ border-color: shade (@dark_bg_color, 0.9);
+ }
+
++PanelApplet .button:prelight:backdrop,
+ PanelApplet .button:prelight {
+ background-image: -gtk-gradient (linear, left top, left bottom,
+ from (shade (@dark_bg_color, 1.7)),
+ to (shade (@dark_bg_color, 1.25)));
+- border-color: shade (@dark_bg_color, 0.78);
+- border-radius: 0;
+- border-width: 0 1px 0 1px;
+-
+- -unico-border-gradient: none;
+- -unico-glow-radius: 0;
+- -unico-inner-stroke-width: 0;
+- -unico-outer-stroke-width: 0;
++ border-color: alpha (shade (@dark_bg_color, 1.0), 0.6);
++ border-left-color: alpha (shade (@dark_bg_color, 1.5), 0.4);
+ }
+
+ ClockBox {

I'm not comfortable accepting this SRU without a clearer explanation of why *none* of these changes have an impact outside of gnome-panel, or why they're otherwise correct in all cases.