Comment 16 for bug 318360

Revision history for this message
Manoj Iyer (manjo) wrote :

The following patch fixes the problem, and is in latest Jaunty kernel. Can you please confirm that you do now see this problem with the latest Jaunty kernel?

commit 73e1a65d3c4a013f6fa56e47133be95143a75fe3
Author: Zhu Yi <email address hidden>
Date: Thu Jan 8 10:19:58 2009 -0800

    iwlwifi: remove CMD_WANT_SKB flag if send_cmd_sync failure

    In function iwl_send_cmd_sync(), if the flag CMD_WANT_SKB is set but
    we are not provided with a valid SKB (cmd->meta.u.skb == NULL), we need
    to remove the CMD_WANT_SKB flag from the TX cmd queue. Otherwise in case
    the cmd comes in later, it will possibly set an invalid address. Thus
    it causes an invalid memory access.

    This fixed the bug http://bugzilla.kernel.org/show_bug.cgi?id=11326.

    Signed-off-by: Zhu Yi <email address hidden>
    Signed-off-by: John W. Linville <email address hidden>