Comment 18 for bug 1334950

Revision history for this message
Takashi Iwai (tiwai) wrote : Re: [PATCH] ALSA: hda - Add mute LED pin quirk for HP 15 touchsmart

At Tue, 19 Aug 2014 15:38:44 +0200,
David Henningsson wrote:
>
> Backport of commit 423044744aa4c250058e976474856a7a41972182.
>
> This makes the mute LED work on a HP 15 touchsmart machine (and
> a HP 14 touchsmart machine).
>
> BugLink: https://bugs.launchpad.net/bugs/1334950
> Signed-off-by: David Henningsson <email address hidden>
> ---
> sound/pci/hda/patch_realtek.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Resend of a patch I tried to send too early.
> The original commit has now reached Linus's tree (it's in 3.17-rc1).

Hm, the patch looks fairly different from the original commit.
Is this because of lack of the new fixup method?

Takashi

>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 6cbbd98..335ffdf 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4429,6 +4429,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x1983, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
> /* ALC282 */
> + SND_PCI_QUIRK(0x103c, 0x2191, "HP Touchsmart 14", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> + SND_PCI_QUIRK(0x103c, 0x2192, "HP Touchsmart 15", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> SND_PCI_QUIRK(0x103c, 0x220d, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> SND_PCI_QUIRK(0x103c, 0x220e, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> SND_PCI_QUIRK(0x103c, 0x220f, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> --
> 1.9.1
>