Comment 7 for bug 2024479

Hi Jo,

Thanks for the bug report, sru template, and debdiffs!

For Mantic, we currently do not have sponsors that could upload, but I certainly can review the debdiff and give you some feedback/request changes before reaching out to another sponsor/uploader, to hopefully make their life easier.

For the Mantic debdiff, it's great, thanks -- just some minor points:

1) the patch file name is 0001-*, and when looking at the tail of the series file, there's already a 0001, and some patches which don't follow a numbered convention? So, my suggestion would be to stick to the 'lpNNNNNNN-patch-subject.patch' convention, for the file name.

2.1) Nice touch on the DEP-3 headers! For Origin:, I just would like to suggest the URL be for the 'commit' page vs. a 'patch' page, which improves readability (colors/visual/etc), but note there's no strict requirement on this.
2.2) On Origin: again, if there's any changes for the patch to apply, please use the 'backport' keyword instead of 'upstream' (I didn't check, so it might be fully correct; but noting it just in case).

(BTW, I could not review the code changes yet.)

Now, on 'finding a sponsor' for Mantic, we can do that for you, or help you with it, in case you'd like to have the exposure/conversation with other people involved in the process. (It's totally fine to pick the former if you're busy or any other reason, this is what we're here for.)

Please confirm which path you'd prefer this time.

Thanks,
Mauricio