Comment 7 for bug 2050019

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2024-03-28 03:42 EDT-------
(In reply to comment #13)
> Well, I was not able to easily cherry-pick these t commits.
> I got merge conflicts due to several debug lines.
>
> After some investigations (using git blame) I found that the commits:
> 0ccac4529540 s390/pkey: harmonize pkey s390 debug feature calls
> 6d749b4e0208 s390/pkey: introduce dynamic debugging for pkey
> seem to be needed - then even some more.
> I finally found that adding the following set of commits (that I've found as
> block earlier in git log):
> 88e4c0da9b08 s390/zcrypt: harmonize debug feature calls and defines
> 08b2c3706de2 s390/zcrypt: introduce dynamic debugging for AP and zcrypt code
> 0ccac4529540 s390/pkey: harmonize pkey s390 debug feature calls
> 6d749b4e0208 s390/pkey: introduce dynamic debugging for pkey
> 6a2892d09df5 s390/ap: add debug possibility for AP messages
> b69b65f51148 s390/zcrypt: add debug possibility for CCA and EP11 messages
> helped me to apply the initial commits.
>
> And with that I was also able to build a test kernel in PPA:
> https://launchpad.net/~fheimes/+archive/ubuntu/lp2050019
>
> Please can you confirm that it's reasonable to go with these (in total now)
> 13 commits instead?

Well, dependent on your kernel base you may need to pull in some more fixes. Best is to simple follow the commit chain. For example with an
git log drivers/s390/crypto
you get the commit chain. Filter out the vfio stuff (or even simpler, pick it also) - this way you get an update of the while AP bus + zcrypt + pkey + vfio stuff. Dependencies to the rest of the kernel are rare and can usually be solved simple by pulling in one patch or so.
Doing the update this way keeps the code consistent and ready for future backports.