Comment 31 for bug 396780

Revision history for this message
Stefan Bader (smb) wrote : Re: [Bug 396780] Re: kernel 2.6.31-2.16 is crashing on boot

Christophe Dumez wrote:
> [290c263bf83cd78e53b1aa3b42165f588163f2be] switch jffs2 to inode->i_acl
> and all commits before that are GOOD.
>
> I'm compiling
> [073aaa1b142461d91f83da66db1184d7c1b1edea] helpers for acl caching + switch to those
>
> as we speak.
>

if that if bad, can you try this change? It looks like doing the wrong thing here.

diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c
index f272bf0..3c88d1b 100644
--- a/fs/jfs/acl.c
+++ b/fs/jfs/acl.c
@@ -67,10 +67,8 @@ static struct posix_acl *jfs_get_acl(struct inode *inode, int
                 acl = posix_acl_from_xattr(value, size);
         }
         kfree(value);
- if (!IS_ERR(acl)) {
+ if (!IS_ERR(acl))
                 set_cached_acl(inode, type, acl);
- posix_acl_release(acl);
- }
         return acl;
  }