Comment 30 for bug 1989203

For the sake of stability, Ubuntu doesn't usually update to an entirely
new version of a piece of software, instead choosing to backport bug
fixes. I tried to do a whole version update since it was mostly bug
fixes, but was told that doing it that way would make review more
difficult, and also Manuskript's development process doesn't appear to
meet all of the qualifications for a full version update to be permitted
usually. It was easier and faster doing it this way (and most of the
reason it took this long was because I tried to do it the other way first).

On 2/10/23 16:53, Biep wrote:
> Ah, all right. Thanks for the explanation.
> Why did you go for an older version, by the way? The newer ones were basically all bug fixes - did you backport all those?
>
> ---- Op vr, 10 feb 2023 22:14:54 +0100 schreef Aaron Rainbolt ----
> > @Biep: There's no need for you to test, that's just an automated message
> > that's pinging you since you filed the bug report. I finally got the fix
> > in, but you're using an already-fixed version from my PPA so you don't
> > need to do anything. I can test the fix so that other users with
> > Manuskript problems can get things working without a PPA.
> >
> > (You're welcome to remove the PPA and install Manuskript from the
> > archive if you prefer once it's all the way in the archive, but the
> > version in the archive is older and might not work as well.)
> >
> > --
> > You received this bug notification because you are subscribed to the bug
> > report.
> > https://bugs.launchpad.net/bugs/1989203
> >
> > Title:
> > Manuskript crashes on start
> >
> > Status in manuskript package in Ubuntu:
> > Fix Released
> > Status in manuskript source package in Jammy:
> > Fix Committed
> > Status in manuskript source package in Kinetic:
> > Fix Committed
> > Status in manuskript package in Debian:
> > New
> >
> > Bug description:
> > [Impact]
> >
> > Manuskript is an open-source tool for writers. Its main purpose is
> > writing novels, books, and the like. It does not have any reverse
> > dependencies.
> >
> > In Ubuntu 22.04 and presumably all flavors thereof (at least Lubuntu),
> > the Manuskript package is currently entirely broken. Attempting to
> > launch it from its button in the application menu does nothing, while
> > attempting to launch it from a terminal results in a very messy error
> > message, which is detailed more thoroughly in the original bug report.
> > This renders Manuskript entirely unusable.
> >
> > This patch backports the following Git commit to the existing version
> > of Manuskript in Ubuntu:
> > https://github.com/olivierkes/manuskript/commit/15edb6efb7305b9d1a192712660857ca38facace
> > This appears to fix the problem in my testing.
> >
> > Those who have Manuskript already installed on their systems currently
> > are unable to use it at all, from my testing. Those who have
> > Manuskript installed already should be able to use Manuskript again
> > after this upgrade is installed.
> >
> > [Test Plan]
> >
> >   1. Install Ubuntu 22.04 or 22.10 into a virtual machine, or use an existing installation thereof.
> >   2. Fully update the new installation (sudo apt update && sudo apt -y full-upgrade)
> >   3. Install the current version of Manuskript (sudo apt install manuskript)
> >   4. Attempt to launch the program from the terminal - the error message described in the original bug report should appear.
> >   5. Enable -proposed and install the new version of Manuskript from -proposed.
> >   6. Attempt to launch Manuskript from the terminal - it should launch successfully this itme.
> >   7. Create a new Manuskript project, make sure that Markdown highlighting works, and
> >   8. Attempt to open the saved project. The saved changes should appear.
> >
> > [Where problems could occur]
> >
> > A typo or malformed line in the patch could potentially result in
> > Manuskript being still unable to launch, or cause strange behavior
> > with the modified code (which appears to deal with colors, and so
> > would likely cause colors somewhere to look wrong). The above test
> > plan will catch major failures, and careful checking of the code (by
> > making sure my patch matches with the upstream commit) should ensure
> > that colors don't end up messed up.
> >
> > ---
> >
> > Original bug report:
> >
> > On Wayland it warns about it not liking Wayland before crashing; on
> > Xorg it immediately crashes on the unhandled exception:
> >
> > biep@blok:~$ manuskript
> > Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
> > CRITICAL> An unhandled exception has occurred!
> > Traceback (most recent call last):
> >   File "/usr/bin/manuskript", line 30, in
> >     main.run()
> >   File "/usr/share/manuskript/manuskript/main.py", line 292, in run
> >     app, MW = prepare(arguments)
> >   File "/usr/share/manuskript/manuskript/main.py", line 171, in prepare
> >     from manuskript.mainWindow import MainWindow
> >   File "/usr/share/manuskript/manuskript/mainWindow.py", line 23, in
> >     from manuskript.models.worldModel import worldModel
> >   File "/usr/share/manuskript/manuskript/models/worldModel.py", line 11, in
> >     from manuskript.ui import style as S
> >   File "/usr/share/manuskript/manuskript/ui/style.py", line 36, in
> >     highlightLight = F.mixColors(highlight, window, .3)
> >   File "/usr/share/manuskript/manuskript/functions/__init__.py", line 197, in mixColors
> >     return QColor(r, g, b) if not fromString else QColor(r, g, b).name()
> > TypeError: arguments did not match any overloaded call:
> >   QColor(Qt.GlobalColor): argument 1 has unexpected type 'float'
> >   QColor(int): argument 1 has unexpected type 'float'
> >   QColor(QRgba64): argument 1 has unexpected type 'float'
> >   QColor(Any): too many arguments
> >   QColor(): too many arguments
> >   QColor(int, int, int, alpha: int = 255): argument 1 has unexpected type 'float'
> >   QColor(str): argument 1 has unexpected type 'float'
> >   QColor(Union[QColor, Qt.GlobalColor, QGradient]): argument 1 has unexpected type 'float'
> >
> > ProblemType: Bug
> > DistroRelease: Ubuntu 22.04
> > Package: manuskript 0.12.0-1
> > ProcVersionSignature: Ubuntu 5.15.0-47.51-generic 5.15.46
> > Uname: Linux 5.15.0-47-generic x86_64
> > ApportVersion: 2.20.11-0ubuntu82.1
> > Architecture: amd64
> > CasperMD5CheckResult: unknown
> > CurrentDesktop: ubuntu:GNOME
> > Date: Fri Sep 9 16:44:06 2022
> > InstallationDate: Installed on 2020-04-27 (864 days ago)
> > InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
> > PackageArchitecture: all
> > SourcePackage: manuskript
> > UpgradeStatus: Upgraded to jammy on 2022-09-08 (1 days ago)
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/ubuntu/+source/manuskript/+bug/1989203/+subscriptions
> >
> >
>
--
Aaron Rainbolt
Lubuntu Developer
https://github.com/ArrayBolt3
https://launchpad.net/~arraybolt3
@arraybolt3:lubuntu.me on Matrix, arraybolt3 on irc.libera.chat