Comment 2 for bug 2060848

Revision history for this message
Andreas Hasenack (ahasenack) wrote : Re: minifycss fails to run in Noble

diff -Nru matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch
--- matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch 1970-01-01 01:00:00.000000000 +0100
+++ matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch 2024-04-10 18:48:17.000000000 +0100
@@ -0,0 +1,37 @@
+Description: Fix paths of the files minify required
+Author: Sudip Mukherjee <email address hidden>
+Bug-Ubuntu: https://launchpad.net/bugs/2060848
+Forwarded: not-needed
+Last-Update: 2024-04-10

You could also add the debian bug to this header:
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068767

I wouldn't block the upload on this, though. But I have another question.

Are there more fixes needed? I just quickly tried to run it with a random css file that is in the same package, and it failed:

$ minifycss ./tests/css/sample/convert_relative_path/source/absolute.css
PHP Fatal error: Uncaught Error: Class "MatthiasMullie\PathConverter\Converter" not found in /usr/share/php/MatthiasMullie/Minify/CSS.php:788
Stack trace:
#0 /usr/share/php/MatthiasMullie/Minify/CSS.php(339): MatthiasMullie\Minify\CSS->getPathConverter()
#1 /usr/share/php/MatthiasMullie/Minify/Minify.php(149): MatthiasMullie\Minify\CSS->execute()
#2 /usr/bin/minifycss(41): MatthiasMullie\Minify\Minify->minify()
#3 {main}
  thrown in /usr/share/php/MatthiasMullie/Minify/CSS.php on line 788

The DEP8 tests also seems to be failing, at least locally:
$ AUTOPKGTEST_TMP=$(mktemp -d) sh debian/tests/upstream
phpab %development% - Copyright (C) 2009 - 2024 by Arne Blankerts and Contributors

Scanning directory ./tests

Autoload file ./vendor/autoload.php generated.

Proceeding without a composer.json file.PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

Warning: Incorrect filter configuration, code coverage will not be processed

............................................................... 63 / 343 ( 18%)
............................................................... 126 / 343 ( 36%)
..............................F....E........................... 189 / 343 ( 55%)
............................................................... 252 / 343 ( 73%)
............................................................... 315 / 343 ( 91%)
............................ 343 / 343 (100%)

Time: 00:00.091, Memory: 12.00 MB

There was 1 error:

1) MatthiasMullie\Minify\Test\AbstractTest::testCache
Error: Class "MatthiasMullie\Scrapbook\Adapters\MemoryStore" not found

/tmp/tmp.w3M8gzyBuN/tests/js/AbstractTest.php:218

--

There was 1 failure:

1) MatthiasMullie\Minify\Test\AbstractTest::testLoadOpenBaseDirRestricted
open_basedir restriction caused minifier to fail
Failed asserting that 0 matches expected 512.

/tmp/tmp.w3M8gzyBuN/tests/js/AbstractTest.php:157

ERRORS!
Tests: 343, Assertions: 352, Errors: 1, Failures: 1.