Comment 11 for bug 1876882

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hello, this patch [1] based on https://gitlab.freedesktop.org/mesa/mesa/-/commit/3dd299c3d5b88114894ec30d1fac85fba688201f
did the trick.

I'll add as part of my ongoing SRU request.

[1]
--- virtualbox-5.2.42-dfsg.orig/include/VBox/HostServices/glxext.h
+++ virtualbox-5.2.42-dfsg/include/VBox/HostServices/glxext.h
@@ -573,7 +573,7 @@ typedef GLXFBConfigSGIX ( * PFNGLXGETFBC
 #ifdef GLX_GLXEXT_PROTOTYPES
 extern GLXPbufferSGIX glXCreateGLXPbufferSGIX (Display *, GLXFBConfigSGIX, unsigned int, unsigned int, int *);
 extern void glXDestroyGLXPbufferSGIX (Display *, GLXPbufferSGIX);
-extern int glXQueryGLXPbufferSGIX (Display *, GLXPbufferSGIX, int, unsigned int *);
+extern void glXQueryGLXPbufferSGIX (Display *, GLXPbufferSGIX, int, unsigned int *);
 extern void glXSelectEventSGIX (Display *, GLXDrawable, unsigned long);
 extern void glXGetSelectedEventSGIX (Display *, GLXDrawable, unsigned long *);
 #endif /* GLX_GLXEXT_PROTOTYPES */
--- virtualbox-5.2.42-dfsg.orig/src/VBox/Additions/common/crOpenGL/dri_glx.h
+++ virtualbox-5.2.42-dfsg/src/VBox/Additions/common/crOpenGL/dri_glx.h
@@ -111,7 +111,7 @@ extern DECLEXPORT(const char *) VBOXGLXT
 extern DECLEXPORT(GLXPbufferSGIX) VBOXGLXTAG(glXCreateGLXPbufferSGIX)
 (Display *dpy, GLXFBConfigSGIX config, unsigned int width, unsigned int height, int *attrib_list);

-extern DECLEXPORT(int) VBOXGLXTAG(glXQueryGLXPbufferSGIX)
+extern DECLEXPORT(void) VBOXGLXTAG(glXQueryGLXPbufferSGIX)
 (Display *dpy, GLXPbuffer pbuf, int attribute, unsigned int *value);

 extern DECLEXPORT(GLXFBConfigSGIX *) VBOXGLXTAG(glXChooseFBConfigSGIX)
--- virtualbox-5.2.42-dfsg.orig/src/VBox/Additions/common/crOpenGL/glx.c
+++ virtualbox-5.2.42-dfsg/src/VBox/Additions/common/crOpenGL/glx.c
@@ -763,7 +763,7 @@ DECLEXPORT(void) VBOXGLXTAG(glXGetSelect
     (void) mask;
 }

-DECLEXPORT(int) VBOXGLXTAG(glXQueryGLXPbufferSGIX)(Display *dpy, GLXPbuffer pbuf,
+DECLEXPORT(void) VBOXGLXTAG(glXQueryGLXPbufferSGIX)(Display *dpy, GLXPbuffer pbuf,
                                                    int attribute, unsigned int *value)
 {
     (void) dpy;
@@ -771,7 +771,7 @@ DECLEXPORT(int) VBOXGLXTAG(glXQueryGLXPb
     (void) attribute;
     (void) value;
     crWarning("glXQueryGLXPbufferSGIX not implemented by Chromium");
- return 0;
+ return;
 }

 DECLEXPORT(int) VBOXGLXTAG(glXGetFBConfigAttribSGIX)(Display *dpy, GLXFBConfig config,