Ubuntu
mozilla-thunderbird package

  1. Bug #239360
  2. Comment #14

Comment 14 for bug 239360

Revision history for this message
In , Johnath (johnath) wrote :

Created an attachment (id=277904)
Use nsIURIFixup for URI construction so that we can handle input with or without scheme

Fixed the problem with us (silently) requiring a well-formatted URI, by using the fixup service to build the URI from the input. There are 2 remaining issues:

1) The added exception does not appear in the web sites list. I need Kai's help figuring out how best to accomplish this, and think it needs to happen before the patch lands.

2) The dialog does not support non-https protocols. This is something we should support, but I think we should land this (and 327181) even without that support. It is launched off the "Web Sites" tab, and adds new functionality. I agree that we should file a follow-up to add broader support, but I don't think we need to block progress on our overall changes to SSL error handling based on this.

Of course, if anyone has a low touch solution for #2, that would be great, but if we can fix #1, I personally think the patch is ready for review.