Comment 11 for bug 45591
Revision history for this message
|
|
#11 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
+ if (i + audio_len >= dataLen)
+ audio_len = (dataLen - i) - 1;
Why are you dropping the last byte of the file?
+ for (PRUint32 j = 0; j < audio_len - 1; j += 2) {
I'd prefer "j + 2 <= audio_len"
+ } else
+ i++;
I'd prefer braces around the i++. Also, is it really correct to scan through the WAV file looking for the string "fmt "? Aren't there other chunks that could have binary data in them that happens to contain the string "fmt "?