Comment 22 for bug 806761

Hi, I've had a quick look at the patch (Patch rev5) but there are a few problems/questions for inclusion into Debian:

- Debian is currently preparing for the next stable release and as such I don't think I will upload this change to Debian unstable any time soon as it could interfere with getting other changes into wheezy.
- Debian doesn't install upstart by default so I don't want to drop the init script just yet. Do you know how upstart behaves if an init script is also present? For being included into Debian it should support both init systems side-by-side.

A few points regarding the patch:
- In nslcd.if-up flock seems to be missing a -c option (I assume the start command is part of upstart).
- What is the reason for adding the recommendation on libsasl2-modules-gssapi-mit | libsasl2-modules-gssapi-heimdal? What extra functionality does it provide to nslcd?
- The post-start script of nslcd checks /etc/init.d/nscd but runs /usr/sbin/nscd. Invalidating nscd can be a good idea but the script should check /usr/sbin/nscd (unscd ships a different init script but supports the nscd command interface).
- The post-stop script stops nscd which it shouldn't do IMO.
- The post-stop script has a debugging date command left over.
- The nslcd.if-up script doesn't support environments without upstart.
- In nslcd.nslcd-k5start.upstart NSLCD_STATEDIR is created before parsing /etc/default/nslcd.
- In nslcd.nslcd-k5start.upstart there is a section script. Isn't a pre-start or start missing?
- It seems debian/rules tries to install a nslcd-kerberos.upstart script but it is named nslcd-k5start.
- debian/rules calls dh_installinit with the --upstart-only option which isn't supported in Debian.
- Passing --noscripts to dh_installinit makes that nslcd is not restarted on upgrades.
- I'm not sure the post-start script in nslcd-k5start works correctly if k5start shouldn't be started ("$K5START_START" != "yes").
(aesthetic point but the scripts use tabs, please only use them in Makefiles)

I've only done a visual inspection of the patch and ran a build but haven't run any further tests. I also don't have a system with upstart handy at the moment.

(I did fix the typo in the development repository so that will go into the next upload)

Thanks for your work on implementing this.