Comment 5 for bug 1224098

Revision history for this message
Alberto Milone (albertomilone) wrote :

SRU request:

[Impact]

 * As a result of this bug, the lightdm configuration file will always been overwritten. This is not desirabled or expected and causes serious problems on any *buntu system other than Ubuntu.

[Test Case]

 * Enable the precise-proposed or the saucy-proposed repository and install nvidia-prime (0.4.2~hybrid0.0.1 in precise or 0.4.2~hybrid0.1 in saucy).

 * If the package doesn't overwrite the lightdm greeter in the lightdm.conf file, then the fix is correct.

[Regression Potential]

 * The regression potential here should be zero, as we only replace two conditions ( "test -f" and "test ! -s") that can never be true at the same time, with the "test -s" condition which does exactly what we need - it checks that the file exists and has a size greater than zero - and reuse the existing file if this condition is satisfied.