Comment 7 for bug 1704817

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

The upload looks fine and I'm *almost* good to accept it to xenial-proposed. I would like to have a bit more detail in the description: could you modify the test case so that one knows what would be the 'expected' result of the test?

A small thing also: for the regression potential, whenever I see just 'None' written I feel like questioning a little bit. The code does look in fact very safe though so it's not a blocking thing, but I was wondering if it's possible that something would be regressed by the 'Version' part being removed from list? Just thinking out loud. Anyway, I guess this would still be better than not working at all. That being said, the Regression Potential field is for guess work like this - thinking of possible scenarios that could cause issues after the update is released to the world.