Comment 10 for bug 2011458

I grabbed this for my SRU shift, but quickly realized reviewing this patch is more complicated than I thought. I concentrated a bit more on the DEP8 test then.

I confess I don't understand how this check is passing:

# Check that ssh.service is currently inactive/dead.
assert_unit_property ssh.service "ActiveState=inactive"
assert_unit_property ssh.service "SubState=dead"

Because autopkgtest just connected to the vm/container over ssh to run this test, so the ssh.service must be active at this point.

When I run this test script in a local container, over ssh, the test fails on the above check, as I expected. But when I throw autopkgtest at it, locally, it passes the check (and I ran it with bash -x to confirm the state of ssh.service). How?

On a review note about the test, if you happen to need to reupload this for whatever reason, I would suggest that you also add some output explaining what is being tested. The comments you have just before each assert are a great example.