The changes you're proposing LGTM, but the d/changelog entry could be improved. In order to not waste time with a back-and-forth exchange of messages regarding this (mostly cosmetic) adjustment, I took the liberty to write the entry myself while still keeping you as the author. Here's what I wrote:
oprofile (1.4.0-0ubuntu8) noble; urgency=medium
* Fix FTBFS due to libbfd's requirement to be linked against libzstd
and libsframe. (LP: #2045844)
- d/control: Build-Depend on libzstd-dev.
- d/p/static-libbfd.patch: Check for -lzstd and -lsframe.
I have also incorporated your changes using git-ubuntu and created a commit (again, with you listed as author) to make sure that we carry this in the rich history.
Uploaded, and therefore unsubscribed ubuntu-sponsors. Thank you.
Thank you, Sudip.
The changes you're proposing LGTM, but the d/changelog entry could be improved. In order to not waste time with a back-and-forth exchange of messages regarding this (mostly cosmetic) adjustment, I took the liberty to write the entry myself while still keeping you as the author. Here's what I wrote:
oprofile (1.4.0-0ubuntu8) noble; urgency=medium
* Fix FTBFS due to libbfd's requirement to be linked against libzstd libbfd. patch: Check for -lzstd and -lsframe.
and libsframe. (LP: #2045844)
- d/control: Build-Depend on libzstd-dev.
- d/p/static-
-- Sudip Mukherjee <email address hidden> Thu, 07 Dec 2023 12:21:47 +0000
I have also incorporated your changes using git-ubuntu and created a commit (again, with you listed as author) to make sure that we carry this in the rich history.
Uploaded, and therefore unsubscribed ubuntu-sponsors. Thank you.