Ubuntu
plasma-widget-indicatordisplay package

  1. Bug #410228
  2. Comment #1

Comment 1 for bug 410228

Revision history for this message
Loïc Minier (lool) wrote :

Packaging looks good, minor points:
- Priority should be optional.
- You might want to add a watch file.
- I see CMakeLists.txt uses pkg-config checks but there's no cmake or kde package deping on it, so I don't know where the pkg-config functions come from but you might have to explicitly build-depend on pkg-config

There's an issue with licensing:
- upstream files lack the full license grant (the blob saying this file is under GPL and you should have received it etc.), they only have "License: GPL v3"
- plenty of files are actually LGPL; this is worth representing in the debian/copyright file at least, or fixing upstream; please ship a copy of the COPYING.LGPL file if you ship files under the LGPL

Upstream code: looks good.

What's the issue with running the testsuite in dbus-launch?

Please subscribe to the bug mail for this package or subscribe the responsible team.