Comment 42 for bug 267141

Revision history for this message
Steve Langasek (vorlon) wrote :

I'm sorry to say that I don't think upgrading pm-utils to the new upstream version is a viable option for intrepid. Backporting a targeted fix may be, if someone wants to look into the code differences; but I think we should consider other fixes in the meantime, even if they end up being short-term.

Of the two patches available, I'm afraid I'm not happy at all with hyperair's, which adds nearly 100% code duplication of the existing uswsusp method; that's not at all elegant or maintainable.

James' patch, while making it more awkward to enable uswsusp, does address the core of this bug, which is that users should not lose the suspend method by having uswsusp installed. Being able to use uswsusp, which is a far-from-preferred method in Ubuntu, is very much secondary.

So I think James' patch is the correct basis on which to move this bug forward. James, it's been mentioned that dropping a file in /etc/pm/config.d with the sleep method is enough to let users enable uswusp. Perhaps we should patch pm-utils to ship a file under /etc/pm/config.d by default, with commented examples of how to enable the alternate suspend methods? I don't believe that installation of the uswsusp package (or tuxonice support in the kernel) should cause these methods to be used automatically, given their non-preferred status within Ubuntu, so an example file seems best to me.