- seems like some of the gstreamer sources changed license (gstpocketsphinx.c, gstvader.*, ...) from LGPL to what is used for the other sources, debian/copyright needs to be updated to reflect that
- the pkgconfig files has -lm added to its Libs.private, libpocketsphinx-dev should get a depends on libc6-dev
- it would be good to describe all the changes you did in the changelog, like you changed the short description to start with a capital letter ... was that a lintian warning?
- could you attach the orig.tar.gz to the bug? I noticed that it has a "dfsg" change to include some license text so it's likely a different tarball than the upstream one
Once those comments addressed it seems like it should be good to upload, I didn't spend a lot of time trying to understand the renaming though, it would be good if whoever re-review it/sponsoring it does that
Thanks, I had a quick review, some comments:
- seems like some of the gstreamer sources changed license (gstpocketsphinx.c, gstvader.*, ...) from LGPL to what is used for the other sources, debian/copyright needs to be updated to reflect that
- the pkgconfig files has -lm added to its Libs.private, libpocketsphinx-dev should get a depends on libc6-dev
- it would be good to describe all the changes you did in the changelog, like you changed the short description to start with a capital letter ... was that a lintian warning?
- could you attach the orig.tar.gz to the bug? I noticed that it has a "dfsg" change to include some license text so it's likely a different tarball than the upstream one
Once those comments addressed it seems like it should be good to upload, I didn't spend a lot of time trying to understand the renaming though, it would be good if whoever re-review it/sponsoring it does that