+ case EROFS: + ignore_failure = true; + xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):"")); + break; default: xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):"")); break;
Instead of reproducing the xwarn() call, I believe this should be:
+ case EROFS: + ignore_failure = true; default: xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):"")); break;
I would prefer to see this reconciled before proceeding with the SRU.
+ case EROFS: failure? _(", ignoring"):""));
default:
xwarn( _("setting key \"%s\"%s"), outname, (ignore_ failure? _(", ignoring"):""));
break;
+ ignore_failure = true;
+ xwarn(_("setting key \"%s\"%s"), outname, (ignore_
+ break;
Instead of reproducing the xwarn() call, I believe this should be:
+ case EROFS:
default:
xwarn( _("setting key \"%s\"%s"), outname, (ignore_ failure? _(", ignoring"):""));
break;
+ ignore_failure = true;
I would prefer to see this reconciled before proceeding with the SRU.