Comment 7 for bug 1903351

Revision history for this message
Steve Langasek (vorlon) wrote :

+ case EROFS:
+ ignore_failure = true;
+ xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):""));
+ break;
                default:
                        xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):""));
                        break;

Instead of reproducing the xwarn() call, I believe this should be:

+ case EROFS:
+ ignore_failure = true;
                default:
                        xwarn(_("setting key \"%s\"%s"), outname, (ignore_failure?_(", ignoring"):""));
                        break;

I would prefer to see this reconciled before proceeding with the SRU.