Comment 4 for bug 2045816

Revision history for this message
Simon Quigley (tsimonq2) wrote :

From my assessment, Aaron missed one thing, which is that Ubuntu MOTU is no longer a valid maintainer.

I would also try to fix these upstream (not a blocker, you could always quilt patch too):

I: project-x: desktop-entry-contains-encoding-key Encoding [usr/share/applications/projectx.desktop:5]
I: project-x: desktop-entry-lacks-keywords-entry [usr/share/applications/projectx.desktop]

And perhaps override or address these:

X: project-x source: update-debian-copyright 2008 vs 2023 [debian/copyright:28]
X: project-x source: very-long-line-length-in-source-file 8448 > 512 [resources/ac3.bin:1]

Overall, I think this is a great start. I'm happy Aaron received experience with reviewing, and I'm glad you're getting experience with bugfixing!

Please provide an updated diff and re-subscribe sponsors, at your convenience.

Thank you!